GeomScale/volesti

Inefficient handling of burn in phase in sampling functions

TolisChal opened this issue · 12 comments

TolisChal commented

In header include/sampling.hpp the sampling functions do not handle the burn in phase efficiently.
They store the points of burn in phase and then they delete them.

RandomPointGenerator::apply(P, p, c, a, eta, nburns, walk_len, randPoints, push_back_policy, rng); randPoints.clear();

We need a new function to perform the burn in phase efficiently.

purna135 commented

I would like to work on this issue

  • 👍1
Rajat1206 commented

I'd like to work on this issue if it's still open!

  • 👍2
nanu1605 commented

@TolisChal Is this still open? I would love to work on it

vissarion commented

@nanu1605 please feel free to open a PR.

hzratali commented

@TolisChal Is this still open? I would love to work on it
Hey, are you working with this issue, if not then please assign me this issue. I would love to work on it.

vissarion commented

@ha-rahman there are no assignments on issues, everyone is free to start working on a issue. The first pull request that is reviewed and approved will be merged.

hzratali commented
KhushV25 commented

hey , can i work on this?

vissarion commented

@KhushV25 sure, please go ahead and submit a PR.

nick2432 commented

can i submit a PR?

  • 👍1
PremBorole commented

hey , can i work on this ? is this still open ?

venom1204 commented

I have a solution to the above problem like
We need a way to perform the burn-in phase without storing the points and clearing them afterward. Instead of storing the points, we can directly discard or ignore them during the burn-in phase.
To fix this issue,I can modify the sampling functions . Instead of storing the burn-in points in randPoints,
we can:
Skip storing the burn-in points altogether.
Or, use a separate burn-in phase without accumulating points in randPoints.

shall i proceed with this approach or do something else ?what you think ? @TolisChal @vissarion