Request: Change behaviour of phase knob in sample mode
Opened this issue · 2 comments
Hi there!
I think the way the "Offset" knob in sample mode currently works is not very useful.
It would be much better if instead this knob would control the sample start position (the position in the sample, from which the playback is started, ranging from start to end of the sample), so you could pick any point in any sample to use.
Other than that very happy with Geonkick so far! Thank You!
This is problematic because Geonkick loads samples into memory from the disk form the start to a maximum of 4 seconds. The length of 4 seconds is the maximum sound length Geonkick can currently produce.
I think the offset should remain because it has a different purpose: delaying the 4s sample that was loaded. The only problem is being able to increase its resolution.
An additional control can be added that will move the start of the sample. For example, when the user changes this control, they will see in the sample waveform that it moves to the left/right, but the offset remains in the same position. But this is limited by the 4s. But I'll think how to can be done.
Definitely, when the preset is saved, the sample will be cut to what is only seen in the waveform of Geonkick sound. Reloading the sample will not load the entire sample anymore; only the part selected, which is saved in the preset.
Oh ok, that seems to make it complicated.
I thought it might be nice to just load a drum loop or any sample and skim through it to find a nice sound, but given those limitations it probably doesn't make too much sense to add this, and might be confusing to the user.
Maybe keep the idea for some future version, but loading one shots like now is totally fine, too.