Support runtime change of samplerate

Question

Support runtime change of samplerate

Opened this issue 2 months ago · 13 comments

My system is as follows:

Device name Panopticon
Processor AMD Ryzen 7 5800H with Radeon Graphics 3.20 GHz
Installed RAM 32.0 GB (27.9 GB usable)
System type 64-bit operating system, x64-based processor
Edition Windows 11 Home
Reaper v7.25

Project details: 48kHz sample rate

Bug present on VST3 and LV2 builds on Geonkick 3.5.0

My current project uses about 6 instances of Geonkick for different samples. Bug occurs when I choose to render my project, and the drum preset I created below:

gets replaced with the initialized preset of the plugin:

This occurs even when freezing my tracks, which also involves rendering, and makes the plugin unusable for me.

Answer 1 · 2024-11-10T09:47:04.000Z

Have attempted to abridge the plugin as shown below, but same bug is still present. Lost presets again.

Answer 2 · 2024-11-10T09:52:44.000Z

Upon rendering, the plugin also appears to not be able to load its abridged GUI, after the bug initializes its preset to default.

Answer 3 · 2024-11-10T10:02:34.000Z

Hi! I've done these steps:

Add two Geonkick MIDI tracks. Edit the wavefrom.
Render to file.
Open again the UI of Geonkick plugins. The states are saved, are not reset.

I am not a reaper user but I hope I have done the steps correctly to reproduce.

On Windows 11, latest version of reaper 7.27

Answer 4 · 2024-11-10T10:14:56.000Z

@fyrebreak I have attached the video of my test.

render.mp4

Answer 5 · 2024-11-10T10:23:38.000Z

@fyrebreak
Here freeze/unfreeze

freezeunfreeze.mp4

Answer 6 · 2024-11-10T10:30:00.000Z

Thanks for trying out the test cases. I'm trying to send a video back as well, but in the meantime here's some things that will hopefully trigger the bug?

Rendering an MP3 file from the render window
Saving a default preset of the plugin on the Reaper dialog window, closing and opening Reaper, and then trying to render an MP3 file again
Changing your sample rate of the project to 48kHz instead of 41kHz

Answer 7 · 2024-11-10T10:38:50.000Z

@fyrebreak Ok, I'll try this too. As you said your preset contains a sample. Is the preset you created loaded ok when you save and load it?

Answer 8 · 2024-11-10T10:42:10.000Z

Thanks, here's my test.
https://github.com/user-attachments/assets/7c3aafa5-10f0-42f0-afaf-33e2148db44c

My preset is okay initially, I could check on the sample if you want to make sure that it's initialised properly.

Answer 9 · 2024-11-10T10:54:23.000Z

2024-11-10.18-50-17.mp4

I believed I nailed something down. I set my project to 44.1kHz in sample rate and it works. Let me know if you're able to replicate the bug at 48kHz as well, or if you'd like me to test other sample rates.

Answer 10 · 2024-11-10T11:10:13.000Z

Updated test. I cannot reproduce. Maybe I am dong something wrong.
https://github.com/user-attachments/assets/447ec380-872c-4c7e-96b5-a1dcced6d851

Answer 11 · 2024-11-10T11:14:26.000Z

2024-11-10.19-12-57.mp4

Try the following?

Answer 12 · 2024-11-10T12:10:54.000Z

@gwee007 @flewkey Ok, I understand what is the problem. If the project is set at a sample rate and if you render to a different rate or at runtime change the sample rate the plugin will reset the state to default state because for now Geonkick do not support this feature. I need to do some implementation.

Answer 13 · 2024-11-10T13:13:15.000Z

Okay, have confirmed what you said and I've changed my render sample rate to be the same as my project sample rate, and it works. Looking forward to 3.6!