GeorgeHop/react-native-country-codes-picker

Update package

kasperkberg opened this issue · 4 comments

kasperkberg commented

Hi,
Thanks for the work! Very much appreciated!

I created a pull request to only show popular countries if there is no searchValue. As long as the popular countries doesn't filter when searching, I would prefer them to go away. Possible to merge that (if it looks ok), and update the package with the types-fixes done 3 weeks ago as well?

kasperkberg commented

And a general question:
There is a notable delay from triggering the modal to open, to it actually opening. Anything I'm doing wrong, or is that the way it is?

  • 👀1
GeorgeHop commented

Updating and merged all your stuff

GeorgeHop commented

The architecture of component looks like that... First we open Modal component from react native and then trigger onShow event which open inner component with animations and other stuff.

GeorgeHop commented

So the delay is related probably to the bridge and the native side. Another case you can try is animate the inner component using useEffect when show state changes, maybe it will be faster but amination may work in a different way in that case.