PyShp 3.0.0-alpha, (Pythons >= 3.9 only). Invoke pytest, and hopefully the main doctest runner too, from pre-commit hooks.

Question

PyShp 3.0.0-alpha, (Pythons >= 3.9 only). Invoke pytest, and hopefully the main doctest runner too, from pre-commit hooks.

JamesParrott opened this issue a year ago · 1 comments

Describe the feature request

A pre-commit config file has been added, together with a job to run its hooks in CI (in build.yml). Invoking Pytest and the doctests from there would make it the natural single source of truth for both the CI checks, and local checks in the dev environment.

Answer 1 · 2024-09-17T12:19:36.000Z

PyShp's tests are currently fast enough for this, running with as little inconvenience as mypy does on the v3 branch. However if more tests are added in future, e.g. Hypothesis, then running them from pre-commit was decided not to be such a great idea, as it would slow down committing: pre-commit/pre-commit-hooks#291