GetStream/stream-chat-swift

Missing super.init in AsyncOperation

dongfanger2018 opened this issue · 2 comments

What did you do?

i don't know whether is's a bug or not
it seems you missing call super.init() in AsyncOperation

What did you expect to happen?

add super.init

What happened instead?

don't know

GetStream Environment

**GetStream Chat version:4.46.0
GetStream Chat frameworks: StreamChat, StreamChatUI
iOS version:
Swift version:
Xcode version:
Device:

Additional context

AsyncOperation is a subclass of nsobject, you should call super.init

image

Hello,

This is not a bug. Calling super.init in this case has no impact.

Best,
Nuno

Hi @dongfanger2018,

Update: We are going to change this either way. Even tho it should have no impact, the docs say that it is recommended to call super.init in NSOperations, here: https://developer.apple.com/documentation/foundation/nsoperation/1808546-init

So we will update it anyways 👍

Best,
Nuno