GetStream/stream-video-android

Can you simplify overriding DefaultNotificationHandler to let customers create own Notification style and look

Opened this issue · 1 comments

Miara commented

Describe the bug
It's very hard to override Notification with your SDK. When I tried to override DefaultNotificationHandler and write my own handler with my own notification style and buttons, I cannot do it, because many methods there are internal or private, so I cannot for example override getIncomingCallNotification because it's private, and I cannot use your DefaultStreamIntentResolver because this is internal.

I report this as a bug, not feature, because I think that your intention was to let people using your SDK customizing notification look, style and behaviour. And indeed - it is possible, hovewer I need to write everything from scratch, and I love to reuse some code that you already wrote - such as DefaultStreamIntentResolver

SDK version

  • 1.0.17

To Reproduce
Steps to reproduce the behavior: Try for example to modify incoming or outgoing notification text 😄

Expected behavior
Almost all internal and private methods in DefaultNotificationHandler should be protected or open, to be able to easily modify and customise notifications.

Hey @Miara

We have added this to our backlog thou we cannot make any promises regarding priority or timeline.
Will keep you posted here.

Regards,
Alex