Gh-Reza/Portfolio

Week 4 - Day 4: Peer to Peer code review ๐Ÿ”Ž๐Ÿ“Œ

Closed this issue ยท 0 comments

Hi @Gh-Reza ๐Ÿ‘‹๐Ÿ‘‹

Great job on your work so far! While you have done an excellent job with the design, there are still some issues that need to be addressed. Keep up the good work! ๐Ÿ’ช๐Ÿ’ช

leonardo-dicaprio-clapping

To highlight ๐ŸŽฏ

  • Good commit history ๐Ÿ‘Œ
  • No linter errors.โœ”๏ธ
  • Nice design. ๐Ÿ‘

Changes That Need to be Made โ™ป๏ธ

  • Enhance the clarity and engagement of the Live Demo section in the README file.
  • Changes to be made in the contact section :
  1. In the <textarea> element, there are two name attributes. You should remove the extra name attribute so that the element only has one.
  2. For accessibility reasons, it is recommended to use <label> elements for each of the form inputs. This helps screen readers to identify the purpose of each form input.
  • To improve the user experience, consider making the background non-scrollable when the popup page is open. You can achieve this by applying the CSS property overflow: hidden;.
  • Consider addressing the issue of the work card cover image appearing pixelated.

Screenshot from 2023-05-18 18-16-20

Cheers, and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘