Primary User Role Deleted

[tr-j]

Describe the bug

We have had a number of staff that have had their primary role in the system nulled out. I have not found the steps to reproduce it, but I think it happens when we upgrade Gibbon.
Because the primary role is not editable there is no way to fix the problem without directly editing the database which makes it annoying to fix.

We also have had some staff that end up with an invalid primary role and the dropdown is not visible and so it must be manually corrected in the database (which then allows the dropdown to appear again so that the field is editable).

An invalid primary role seems to prevent users from logging in.

Screenshots

Your System

• This has occurred on multiple versions of recent Gibbon

Additional context

[SKuipers]

This is unusual, and not something we've seen before. It doesn't appear to be related to a rollover or system update, but from your screenshot it does look like the primary role dropdown is missing when editing a user, which could cause the primary role to become unset. In Manage Roles, you can determine who has the ability to give that role to another user, with the default Restriction being None.

I suspect that you may have set your staff role to be too restricted, in that when your administrative staff are editing those staff users, they do not have access to set the role for those staff. Try setting the restriction back to None for your staff role and you shouldn't see the Primary Role show up as blank (for a user where it was not already blank). There may be a bug here, in that it shouldn't be changing the role should this edge case occur, which I'll look into, but I suspect the quick fix is to adjust your Role restrictions.

[tr-j]

Thanks for the response on this. My user is an administrator and I cannot edit any of the blank roles. One of our staff members manages all of the users and she is an administrator as well. It is editable when it isn't blank. We have a custom role that we had some users assigned to, but at some point it seems to have disappeared (I think during an upgrade). I believe that orphaned some of the users. That seemed like the cause initially, but it seems like the issue is popping up again after being manually fixed. I'll inform anyone who can edit user records to watch out for the blank role and we'll see if we can narrow it down further. Thanks.

…

On Mon, Sep 20, 2021 at 8:43 AM Sandra Kuipers ***@***.***> wrote: This is unusual, and not something we've seen before. It doesn't appear to be related to a rollover or system update, but from your screenshot it does look like the primary role dropdown is missing when editing a user, which could cause the primary role to become unset. In Manage Roles, you can determine who has the ability to give that role to another user, with the default Restriction being None. [image: Screenshot 2021-09-20 at 10-11-05 DEMO - Gibbon - User Admin] <https://user-images.githubusercontent.com/897700/133951343-cc1ec1f0-3620-4455-8cf1-4357591dedf0.png> I suspect that you may have set your staff role to be too restricted, in that when your administrative staff are editing those staff users, they do not have access to set the role for those staff. Try setting the restriction back to None for your staff role and you shouldn't see the Primary Role show up as blank (for a user where it was not already blank). There may be a bug here, in that it shouldn't be changing the role should this edge case occur, which I'll look into, but I suspect the quick fix is to adjust your Role restrictions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUWNGLLRGVTZPFH6AZNHONDUC2KDNANCNFSM5EEBN32Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[SKuipers]

If a role was deleted from the system at some point, that could certainly cause blank fields in the Edit User screen for Primary Role. One option is to run some SQL to set all the affected users back to a default Support Staff role and use the following SQL to update those users:

UPDATE gibbonPerson SET gibbonPerson.gibbonRoleIDPrimary=006 WHERE gibbonRoleIDPrimary IS NULL OR gibbonRoleIDPrimary='';

Then, in Manage Roles, when you View the Support Staff role, it will tell you who those users are, and you can update their roles as needed.