PDF Options
Closed this issue · 2 comments
kshunterco commented
Hi
Thank you for this nice code. Works great as long as there isn't a CAPTCHA on the other end 🤣
I am wondering if you would be OK with two changes:
- An additional option for PDF enabling selection of A4 or Letter sizing
- A revision to the pdf.Image() call that would cause gofpdf render the image with original aspect ratio rather than forcing to the A4 aspect. As far as I can tell (I could very much be wrong), setting the w, h options will force to a specific aspect. I have used your code to download some comics that have two-page images, and they are getting squished to a single page. Not desirable.
I have downloaded the source and built the exe under Windows... I may be able to make these changes myself after a few more days of understanding go, but I have never contributed to anything on GitHub so I'll need to figure that out as well.
Best
KSH
kshunterco commented
Hahahahaha well gee wiz the simple fix didn't work. Looks like it would require pdf.AddPageFormat() with specific orientations. This is getting more complex, but it's still fun. I'll see what I can do before you get back to me.
kshunterco commented
This can be closed. I created a pull request... More details there.