All formats broken, unless images-only is used first
wooosh opened this issue · 3 comments
Describe the bug
Any option/format on every host I've tried will produce an empty folder, unless I call comics-downloader once with image-only, then call it again with the desired format.
To Reproduce
comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
# at this point, manga/comics/mangakakalot.com/Chapter 1 is created, but contains no files
comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -images-only
comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
# now cbz file is present
Expected behavior
The cbz should be able to be created without running a command separately to download the images first, which worked in the last stable release.
Desktop (please complete the following information):
- OS: Void Linux
- Version v0.31.0 (latest master at time of bug report)
- Type: Command Line
Hey @wooosh thanks for the report!
I tried with v0.31.0 and master and comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
works.
I have managed to narrow down the issue. I believe it is related to relative paths in some way, since this works:
./comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
but this does not:
./build/comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
At this point I am not sure if this is consider user error or a bug, so feel free to close it if relative paths are not supported in this manner.
Let's leave this issue open, maybe we can change the title as it could be misleading.
./build/comics-downloader -url=https://mangakakalot.com/manga/oj918337 -range 1-1 -output=manga -format=cbz
When executed like that I see 2 folders being created/used, the first one within the build folder (where the cbz file is going to be saved), the other one is the relative path passed to the output flag where the folder structure is going to be created anyway. Something is clearly wrong here.
Workaround
For now the workaround is to provide a full path to the output flag when the downloader is executed like
./build/comics-downloader