GitHawkApp/StyledTextKit

Make NSLinkAttribute to tappable and highlighting.

ryohey opened this issue · 4 comments

Hi, Thank you for this amazing library.

I have a question about links and attributes.
StyledTextKit provides three attributes .tapable, .tapHighlight, .highlight.
Are there use-cases for using these attributes separately?
These just increase complexity in my opinion.

As alternative for UITextView, Is it not enough to have only NSLinkAttribute?

@ryohey NSLinkAttribute has some weird default styling that you can't override, pretty funky behavior.

.tapable is only in an example

We could def use some documentation the two highlight options.

@kylelol now that I'm reading the code, did #47 change the behavior of .highlight? If you were previously using that to do interactive highlighting, do you now have to know to update your code to use .tapHighlight from now on?

@rnystrom oh i see. I didn't know that's behavior. now I think it is a good to use .highlight.
I hope that .highlight is the only attribute to do interactive highlighting.

@rnystrom ah you are right, I think if you were previously using .highlight you would have to update your code to use .tapHighlight. I can switch it back to the way it was to prevent regressions, and maybe pick a more descriptive name like .interactiveHighlight

@kylelol that’d be great!

Sent with GitHawk