The showing Unlock Date is wrong in Locked GIV details on OPTIMISM
Closed this issue · 8 comments
based on @RamRamez's report this bug has been raised
I'v locked some GIV on OPTIMISM for 4 round, the unlock date is shown 14 Nov but after locking in Locked GIV Details this date is shown 19 Nov
The root cause is your position is not unlocked. I think the devops team has not deployed givpower-bot for staging env yet. @mhmdksh
This problem happens on production
@maryjaf hmm... let me check.
@maryjaf hmm... let me check.
Do we have any update about this bug on production? @MohammadPCh
Thank you @maryjaf for reporting,
our rounds start and finish on Tuesdays. the number that we show in the lock modal, is calculated in the front-end and the number that we show in the locked GIV details is coming from the backend. Nov 14th is Tuesday but Nov 19th is not. so we need to check unlockableAt property in the backend.
@aminlatifi @mohammadranjbarz could you please take a look?
We made a mistake in deploying GIVpower on OP network. Its timing is not synced with production rounds and we have used the same value set on staging.
@divine-comedian
@divine-comedian Based on my calculation, this change in OP UnipoolGIVpower can align round ends
1654415235 -> 1654012800
In human-readable format:
Sunday, June 5, 2022 7:47:15 -> Tuesday, May 31, 2022 16:00:00
This will move window about 5 days behind
Amin and I made the update by upgrading the smart contract - multisig tx is pending here:
https://app.safe.global/transactions/queue?safe=oeth:0x4D9339dd97db55e3B9bCBE65dE39fF9c04d1C2cd
@aminlatifi will need to update the unlock values manually in the subgraph to match the new corrected unlock dates
Merged subgraph to production, @maryjaf tested and is happy with it