image doesn't load in verification wizard

Question

image doesn't load in verification wizard

Opened this issue 3 years ago · 10 comments

I'm verifying my project on the wizard. I used one of the default giveth.io project photos.

when I arrive at the wizard my image doesn't show up where it normally should, it looks like its broken -

Answer 1 · 2021-09-25T14:02:31.000Z

This issue is actually related to giveth.io. If user uses app default SVGs as a project image, a number will be saved in DB except of SVG url. That is weird!

Answer 2 · 2021-09-25T16:03:07.000Z

I made those images hidden in verification in PR #2547

We should fix this in giveth.io (#261)

Answer 3 · 2021-09-27T10:34:59.000Z

I made those images hidden in verification in PR #2547

We should fix this in giveth.io (#261)

@RamRamez
I've fixed that in the backend, could you confirm if it is ok?

Answer 4 · 2021-09-27T14:33:13.000Z

As I talked with @mohammadranjbarz, this issue needs a minor change in backend, so I move it to in progress.

Answer 5 · 2021-09-28T10:45:54.000Z

@RamRamez
Could you test it again?
We merged another PR and I created a verified campaign (with no image in givethio) and it was ok

https://develop.giveth.io/campaign/demo-slug

Answer 6 · 2021-09-28T10:48:22.000Z

Thanks @mohammadranjbarz. I move this issue to UAT test.

@divine-comedian Can you test it?

Answer 7 · 2021-09-28T14:47:29.000Z

testing now on develop.giveth.io

I can see the image is no longer broken but it looks like default image isn't quite right.

This is how my project looks on next.giveth.io

and this is the image shows up in the verification wizard -

ideally a user who chooses any of these default giveth.io project images would have the same image when they migrate their project to giveth TRACE.

I will note that these default images might change as we redesign our platforms in the future

Answer 8 · 2021-09-28T14:58:14.000Z

testing now on develop.giveth.io

I can see the image is no longer broken but it looks like default image isn't quite right.

This is how my project looks on next.giveth.io

and this is the image shows up in the verification wizard -

ideally a user who chooses any of these default giveth.io project images would have the same image when they migrate their project to giveth TRACE.

I will note that these default images might change as we redesign our platforms in the future

Yeah because the images are numbers in givethio
for instance "1", "2" ,...
we don't know what is it, so we set our default image for that. ( doesn't matter whats the image in givethio)

Showing exactly that one make our codes a little messy, but if the product need it we can do it ( although I think if a project doesn't have an image in giveth it would not have lots of chances to become verified)
@MoeNick what do you think?

Answer 9 · 2021-09-28T15:01:19.000Z

@divine-comedian Thanks for reporting this.

I have reported this issue in IO #261.
We should fix it there.
If we fix it there, the default images will be automatically shown here.

Answer 10 · 2021-09-29T13:57:51.000Z

@mohammadranjbarz

You raise a really great point. I'm okay with calling the present state "good enough" because you're right, it's very unlikely a project would succeed verification without a unique photo.