GoogleChromeLabs/chromeos_smart_card_connector

Popup dialogs are created with wrong width

Closed this issue · 2 comments

When a dialog (e.g., the built-in PIN dialog in example_cpp_smart_card_client_app) is opened, it gets a wrong width instead of the one specified in the code.

I think it regressed in #518: this line shouldn't have been deleted:

Object.assign(createWindowOptions, opt_createWindowOptionsOverrides);

And there's another issue introduced in #404, when the format of the "width"/"height" parameters has changed, but the example PIN dialog callsites weren't updated accordingly.