GoogleChromeLabs/form-troubleshooter

Standardize `auditType` naming

Opened this issue · 0 comments

During my refactoring of the audits, I introduced a field called auditType which has been used inconsistently. Sometimes it is used to represent when items DO NOT meet a criteria and are therefore invalid (e.g. autocomplete-valid), other times it is used to indicate which fields DO meet the criteria and are therefore invalid (e.g. autocomplete-off).

This issue is to standardize how auditType should be used. I'm leaning towards indicating which fields do meet the criteria and are therefore invalid. Examples:

  • autocomplete-invalid
  • autocomplete-off