GoogleChromeLabs/jsvu

jsvu vs xs 9.0.2

leobalter opened this issue · 7 comments

leobalter commented

Something is going wrong when I try to fetch xst with jsvu:

✔ Found latest XS version: v9.0.2.
✔ URL: https://github.com/Moddable-OpenSource/moddable-xst/releases/download/v9.0.2/xst-mac.zip
✔ Download completed.
❯ Extracting…
Installing binary to ~/.jsvu/engines/xs/xs…
Installing symlink at ~/.jsvu/xs pointing to ~/.jsvu/engines/xs/xs…
✔ Extraction completed.
❯ Testing…
✖ Error: Command failed with exit code 1 (EPERM): /Users/leo/.jsvu/xs -e print('Hi!');

➜  ~ xs -e print('Hi')
zsh: unknown file attribute: H

➜  ~ xs -e "print('Hi')"
TypeError: (host): C: xsCall: no function

I didn't have time to investigate the problem yet but I'm reporting here already.

cc @patrick-soquet

patrick-soquet commented

Thank you for the report. Only the -e option is broken. I forgot to test it because I never use it. Sorry. It will be fixed in the next release.

The -s and -m options that you are using for test262 should work well.

mgol commented

@patrick-soquet This is still breaking running jsvu if you have XS installed. Any chance for a quick fix?

patrick-soquet commented

Sorry for the delay. xs 9.0.3 has been released to fix this issue

  • 🎉1
  • 🚀1
mathiasbynens commented

Actually, I'm still hitting the error even with xs v9.0.3:

✔ Found latest XS version: v9.0.3.
✔ URL: https://github.com/Moddable-OpenSource/moddable-xst/releases/download/v9.0.3/xst-lin64.zip
✔ Download completed.
❯ Extracting…
Installing binary to ~/.jsvu/engines/xs/xs…
Installing symlink at ~/.jsvu/xs pointing to ~/.jsvu/engines/xs/xs…
✔ Extraction completed.
❯ Testing…
✖ Error: Command failed with exit code 1 (EPERM): ~/.jsvu/xs -e print('Hi!');

@patrick-soquet Have you verified the fix?

patrick-soquet commented

I had but then I uploaded the former version of the Linux builds. Sorry for that. I updated the release, it should be better.

  • 🎉1
michaelficarra commented

@mathiasbynens maybe it would be good to check that the output of a "version" flag contains the version we think we're installing?

$ ~/.jsvu/xs -v
XS 9.0.1
mathiasbynens commented

@michaelficarra I considered that originally, but ran into too many issues such as javascriptcore not having a version flag and spidermonkey outputting something like JavaScript-C72.0 whereas the version identifier jsvu installs it from is v72.0b8.