lighthouse bot succeeds even when minimum required threshold is not met

Question

lighthouse bot succeeds even when minimum required threshold is not met

RVledder opened this issue 6 years ago · 3 comments

See the output table on: StudioSpindle/spindle.wtf#7 (comment)

The settings in Travis are set like this: https://github.com/StudioSpindle/spindle.wtf/blob/develop/.travis.yml

Is this a bug or is it a setting that is wrong?

Answer 1 · 2019-07-16T08:30:41.000Z

@StudioSpindle I had a similar issue. I found out it takes some time until the lighthousebot account responds to the invitation to collaborate.

You can check this here:

Answer 2 · 2019-07-25T18:30:42.000Z

Until Lighthouse accepts the invitation to collaborate it does not have permission to fail a check.
However, it will post a comment on your PR.
Here is the original issue Issue 8

@erezrokah How long did you have to wait for acceptance? I requested collaboration 6 days ago.

Answer 3 · 2019-07-25T19:05:08.000Z

@EoinTraynor I don't remember exactly. I think a couple of hours