add support for node engine 18 for @squoosh/lib

Question

add support for node engine 18 for @squoosh/lib

pumano opened this issue 3 years ago · 26 comments

Is your feature request related to a problem? Please describe.
Problem when l need to use --ignore-engines flag for using @squoosh/lib with nodejs 18

Describe the solution you'd like
add support nodejs 18 to:

https://github.com/GoogleChromeLabs/squoosh/blob/dev/libsquoosh/package.json#L22-L24

Does other service/app have this feature?
Add any service you know/use that has this feature (We want to know for research)
https://github.com/bcheidemann/squoosh-webpack-plugin
Additional context
Add any other context or screenshots about the feature request here.

message commented 2 years ago

bump

JacobWeisenburger commented 2 years ago

thanks

Answer 1 · 2022-05-12T23:26:17.000Z

This change may be need too: emscripten-core/emscripten#16917

Answer 2 · 2022-07-14T06:43:09.000Z

Can somebody confirm if this mean that when a package is published relying on squoosh it will crash the package on the client if they don't have node 14 or 16? I was about to use squoosh in a published gltf converter.

Answer 3 · 2022-07-15T20:01:04.000Z

Any updates on this? Is there a workaround for now? Thank you in advance.

Answer 4 · 2022-07-15T21:41:43.000Z

Please let us know if a PR would be welcome for this issue. Thanks! 🙏

Answer 5 · 2022-07-18T20:15:09.000Z

Upvote this

Answer 6 · 2022-07-20T19:31:47.000Z

I filed #1265 but I suspect my issue is actually related to using Node 18

Answer 7 · 2022-10-31T19:55:02.000Z

Are we just thinking of updating the engine rules? No changes needed from squoosh itself?

Switching to Node 18, I get this error.

TypeError: Failed to parse URL from /foo/node_modules/@squoosh/lib/build/imagequant_node-a4aafbae.wasm
    at Object.fetch (node:internal/deps/undici/undici:11118:11) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL

Answer 8 · 2022-10-31T21:02:41.000Z

Found the issue - #1033.

Answer 9 · 2022-11-05T17:22:21.000Z

I am getting this error too.

TypeError: Failed to parse URL from ......./node_modules/@squoosh/lib/build/imagequant_node-a4aafbae.wasm

Node.js 18

Answer 10 · 2022-11-23T05:53:55.000Z

work around for node >= 18, run node --no-experimental-fetch ./script.js

Answer 11 · 2022-11-23T15:20:33.000Z

Hello @GoogleChromeLabs team!
cc @surma @jakearchibald 😸

Any news about NodeJS 18 support? This is a serious issue.
I was surprised that the latest version of Squoosh was published more than a year ago..

The v16 is now in "maintenance" mode and will be dropped 2023.
See https://github.com/nodejs/release#release-schedule.

Answer 12 · 2022-12-05T05:44:23.000Z

work around for node >= 18, run node --no-experimental-fetch ./script.js

can you share your ./scripts.js ? or a sample code ?
thanks

Answer 13 · 2022-12-07T13:29:25.000Z

@limenote simply run node with the --no-experimental-fetch flag, and don't rely on the native fetch implementation.

Answer 14 · 2022-12-07T16:09:47.000Z

but is squoosh to be supported?

Answer 15 · 2022-12-27T21:36:20.000Z

running --no-experimental-fetch worked for me

Answer 16 · 2023-01-03T14:11:38.000Z

Unfortunately, due to a few people leaving the team, and staffing issues resulting from the current economic climate (ugh), the CLI and libsquoosh packages are no longer actively maintained. I know that sucks, but there simply isn't the time & people to work on this. If anyone from the community wants to fork it, you have my blessing. The squoosh.app web app will continue to be supported and improved.

Answer 17 · 2023-01-03T14:34:27.000Z

@jakearchibald
Does the squoosh.app web app support rest endpoints or some way of using it programmatically?

Answer 18 · 2023-01-04T00:06:08.000Z

@jakearchibald Can you or someone else suggest some good alternatives to @squoosh/lib?

Answer 19 · 2023-01-04T00:42:10.000Z

@websours if you need similar functionality in a library format for Node.js, I would consider Sharp, which is based on libvips. There appears to be some effort underway to bring libvips to WASM for web browsers as well. Since Node.js 18 is the subject of the thread here, I've confirmed that Sharp is working fine in that environment.

Answer 20 · 2023-01-04T12:31:28.000Z

@jakearchibald sad, but that's so reflective of the reality of open source projects right now, see project like Atom inside Github team...

Anyway, thanks a lot for letting us know! 🙏 😉

Answer 21 · 2023-01-04T13:35:18.000Z

@JacobWeisenburger

@jakearchibald Does the squoosh.app web app support rest endpoints or some way of using it programmatically?

It doesn't. It's entirely client side. Part of the privacy benefits is the image doesn't leave your device.

Answer 22 · 2023-01-04T14:13:30.000Z

Sounds good. thanks.

Answer 23 · 2023-10-15T15:48:10.000Z

I'm using yarn to build my Next.js application using the command yarn build and getting this error. How could I run --no-experimental-fetch with yarn?

Answer 24 · 2023-10-26T06:51:49.000Z

I'm using yarn to build my Next.js application using the command yarn build and getting this error. How could I run --no-experimental-fetch with yarn?

"build": "NODE_OPTIONS=--openssl-legacy-provider NODE_OPTIONS=--no-experimental-fetch next build"

its work for me