GKE node pool upgrade settings are not configurable
Closed this issue · 3 comments
Describe the bug
In toolkit, GKE node pool upgrade settings are hardcoded:
cluster-toolkit/modules/compute/gke-node-pool/main.tf
Lines 62 to 66 in 26fafe0
This stops us from efficiently upgrading nodes in-place. Without change, each node upgrade can take up 9+ minutes, which makes maintaining big node pools unrealistic.
Steps to reproduce
Steps to reproduce the behavior:
- Trigger in-place node pool upgrade
Expected behavior
You have an option to make sure multiple nodes are made unavailable time to minimize the downtime.
Actual behavior
You don't have any option to upgrade more than one node at a time.
Quick question, you are okay with SURGE
strategy , but want to configure more than one node unavailable
at a time ?
yes. In our particular case, being able to set higher value for max_unavailable
while keeping everything else as is, would be enough.