GoogleCloudPlatform/continuous-deployment-on-kubernetes

Pushing a 'production' branch will deploy to the 'production' namespace

lvdh opened this issue · 2 comments

lvdh commented

(... unless I am missing something.)

Granted, this is an edge case. However, it could be fixed with a straightforward and non-intrusive change. Being an example for an actual production setup, I believe this change would be a worthwhile addition.

Initial suggestion of a fix.

As per the contribution guidelines, I will submit a PR only if the proposed change is accepted.

Hey @lvdh that sounds great!!! Lets make it happen.

(Apologies for the delay).

lvdh commented

Hi @viglesiasce, PR created; #116

Allow me to kindly refuse your apologies, and offer you mine. Apologies for the considerable delay!