GoogleCloudPlatform/emblem

Playwright dependency versions not all available on Renovate schedule

grayside opened this issue · 1 comments

Proposal

  1. Override the schedule for Playwright: have it run daily. Give the dependencies a chance to flow.
  2. Increase stabilityDays for Playwright: Current global config is 3 days. Let's boost to 7 days. In theory, this will require the dependencies to all hold still a bit longer and will prevent Renovate from opening a PR until the change has a chance to settle.
  3. Add a prBodyNote that if the versions don't match exactly, do not merge the renovate update.
  4. Add a reference to this issue to the playwright-dependencies decision record.

Problems this will solve

I am seeing cases such as #819 where a PR updating playwright comes through and passes, but somehow leaves us in a broken state in later PRs.

    browserType.launch: Executable doesn't exist at /ms-playwright/chromium-1048/chrome-linux/chrome
    ╔══════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just updated to 1.31.2. ║
    ║ Please update docker image as well.                                  ║
    ║ -  current: mcr.microsoft.com/playwright:v1.32.3-focal               ║
    ║ - required: mcr.microsoft.com/playwright:v1.31.2-focal               ║
    ║                                                                      ║
    ║ <3 Playwright Team                                                   ║
    ╚══════════════════════════════════════════════════════════════════════╝

I have a couple theories about what is happening:

  1. All relevant playwright updates are not being opened, because updates that occur after the scheduled Renovate run are not opened until the next 2 week interval.
  2. The timing of playwright dependency update availability may be staggered

@muncus suggested keeping to the current stabilityDays count.