GoogleCloudPlatform/getting-started-java

Misleading Javadoc in the Spring Boot sample

Closed this issue · 1 comments

The Javadoc of the Spring Boot sample says

App Engine health checking</a> requires responding with 200 to {@code /_ah/health}.

However, that is not really true, according to the official doc: https://cloud.google.com/appengine/docs/flexible/python/how-instances-are-managed#health_checking

You do not have to do anything special to implement health checking. If your app does not handle health checks, a HTTP 404 response is interpretated as a successful reply.

I think Spring Boot will return 404 by default (unconfimed), so maybe @RequestMapping("/_ah/health") is not necessary either.

lesv commented

@jabubake Don't know if you have cycles for this, if not assign back to me. At one time, the /_ah/health was required - perhaps it's not now.