GoogleCloudPlatform/gke-autoneg-controller

Unused ConfigMap in deploy manifest

jawnsy opened this issue · 1 comments

jawnsy commented

The deploy manifest includes a ConfigMap that does not appear to be used (it is not mounted to the Deployment). Can it be removed?

apiVersion: v1
data:
controller_manager_config.yaml: |
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
health:
healthProbeBindAddress: :8081
metrics:
bindAddress: 127.0.0.1:8080
webhook:
port: 9443
leaderElection:
leaderElect: true
resourceName: 9fe89c94.controller.autoneg.dev
kind: ConfigMap
metadata:
labels:
app: autoneg
name: autoneg-manager-config
namespace: autoneg-system

rosmo commented

Yeah, I don't think that is important - happy to take a patch to remove it. I think it made it's way into the Terraform example as well.