GoogleCloudPlatform/gke-monitoring-tutorial

Should Jenkins test with make or terraform?

milesmatthias opened this issue · 1 comments

sh "make create"

The instructions in the README tell people to do:

./scripts/generate-tfvars.sh
terraform init
terraform plan
terraform apply
terraform destroy

Should Jenkins run those steps to verify that when someone downloads this repo and tries to follow the instructions, everything will work? #17 is an example where following the instructions produced an error that make did not produce.

All our demos need to use make. Some of the docs are out of date.