GoogleCloudPlatform/govanityurls

[Action Required] Upgrade your App Engine Standard applications to Go 1.11 or 1.12 before October 1, 2019

tamalsaha opened this issue · 8 comments

Today, I received an email like this.

Action-Required-Upgrade-your-App-Engine-Standard-applications-to-Go-1-11-or-1-12-before-October-1-2019-tamal-appscode-com-AppsCode-Inc-Mail

Does anyone know what things I need to update?

cc: @rakyll

Redeploying the app to Go 1.11 should work without change. If you want to use Go 1.12, then you may have to tweak main.go to load your file without giving a command-line argument, but it should still largely work.

@zombiezen , I tried to change the app.yaml to this.

runtime: go111

handlers:
- url: /.*
  script: _go_app

I get this error: File upload done. ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: script field for handler '/.*' must be set to 'auto' for runtime go111.

https://cloud.google.com/appengine/docs/standard/go111/go-differences page seem to recommend some additional changes.

Change script: to auto instead of _go_app and it seems to work fine on go112.

EDIT: The other thing to note is that appengine.go is no longer used and main.go is built under go 1.12 in app engine. It still works fine, but it should use the PORT environment variable instead of hard coding 8080. Example: golift#2

@davidnewhall I think I addressed all of these in #34

I don't think this project is getting more updates. You're probably best off forking or picking one of the up to date forks that already exist. I forked and went hard core with the changes. See here https://github.com/golift/turbovanityurls. Good luck! EDIT: I also need to go do some maintenance and updates..

Closed via #34.

(Note: I added some more contributors including @philips to the repo.)

Sweet!