Client-go 0.18.6 version issue for component.go
Opened this issue · 0 comments
Adianldj commented
Met this issue when doing upgrade for k8s 1.18.6:
# github.com/GoogleCloudPlatform/k8s-cluster-bundle/pkg/clientset/versioned/typed/bundle/v1alpha1
/github.com/!google!cloud!platform/k8s-cluster-bundle@v0.12.6/pkg/clientset/versioned/typed/bundle/v1alpha1/component.go:71:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("components").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
have ()
want (context.Context)
This is because client-go:0.18.6(used for k8s 1.18.6) which expects a context to do the call:
https://github.com/kubernetes/client-go/blob/v0.18.6/rest/request.go#L92
However, for k8s-cluster-bundle(latest) is using client-go:0.15.11:
https://github.com/GoogleCloudPlatform/k8s-cluster-bundle/blob/master/go.mod
which does not expect context to do the call:
https://github.com/kubernetes/client-go/blob/v0.15.11/rest/request.go#L805
Could we update current cluster bundle dependency for client-go to solve the issue.