GoogleCloudPlatform/ml-on-gcp

sunparty's unresolved feedback on GCE survival training

zomglings opened this issue · 8 comments

zomglings commented

This issue is in reference to this review.

  1. Why is worth installing the SDK (prerequisites section)?

  2. Custom images - change it to sunparty's recommendation in the review.

  3. Delivery mechanism section - see review.

  4. Startup scripts - see review.

  5. Remove "we will", "we could", etc.

  6. Broken link - "our example startup script".

  7. Notes and references -- see review.

zomglings commented

"Why is it worth installing the SDK?"

I decided to remove the statement about it being worth installing, as there is already a link to the Cloud SDK page and users can make up their own minds.

zomglings commented

Custom image section change - done

zomglings commented

Delivery mechanism done.

Startup scripts done.

zomglings commented

"we will" -> "we", "We will" -> "We"

zomglings commented

Fixed startup script link

zomglings commented

"Notes and references" section fixed.

zomglings commented

Submitted fixes as PR 17

andrewferlitsch commented

Since a PR was submitted, I am closing this "old" issue.