ESLint Extend Google
grant opened this issue · 1 comments
grant commented
Similarly to the PR here, What do you think about extending google?
extends:
- 'google'- Perhaps the
Missing JSDoc commenterror could be suppressed as a warning. - I found the space after function in
function () {a bit off.
Example output:
> nodejs-getting-started@1.0.0 lint /Users/timmerman/Documents/github/nodejs-getting-started
> eslint '**/*.js'
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/books/crud.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/books/model-cloudsql.js
36:1 error Missing JSDoc comment require-jsdoc
54:1 error Missing JSDoc comment require-jsdoc
65:1 error Missing JSDoc comment require-jsdoc
86:1 error Missing JSDoc comment require-jsdoc
97:1 error Missing JSDoc comment require-jsdoc
127:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/books/model-datastore.js
20:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
42:1 error Missing JSDoc comment require-jsdoc
70:1 error Missing JSDoc comment require-jsdoc
91:1 error Missing JSDoc comment require-jsdoc
116:1 error Missing JSDoc comment require-jsdoc
136:1 error Missing JSDoc comment require-jsdoc
140:1 error Missing JSDoc comment require-jsdoc
157:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/config.js
64:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/2-structured-data/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
76:9 error 'data' is never reassigned. Use 'const' instead prefer-const
124:9 error 'data' is never reassigned. Use 'const' instead prefer-const
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/books/model-cloudsql.js
35:1 error Missing JSDoc comment require-jsdoc
51:1 error Missing JSDoc comment require-jsdoc
61:1 error Missing JSDoc comment require-jsdoc
81:1 error Missing JSDoc comment require-jsdoc
91:1 error Missing JSDoc comment require-jsdoc
121:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/books/model-datastore.js
19:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
40:1 error Missing JSDoc comment require-jsdoc
68:1 error Missing JSDoc comment require-jsdoc
70:7 error 'results' is never reassigned. Use 'const' instead prefer-const
88:1 error Missing JSDoc comment require-jsdoc
111:1 error Missing JSDoc comment require-jsdoc
130:1 error Missing JSDoc comment require-jsdoc
134:1 error Missing JSDoc comment require-jsdoc
151:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/config.js
69:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/lib/images.js
21:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
30:1 error Missing JSDoc comment require-jsdoc
40:1 error Missing JSDoc comment require-jsdoc
77:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/3-binary-data/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/books/model-cloudsql.js
35:1 error Missing JSDoc comment require-jsdoc
52:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
79:1 error Missing JSDoc comment require-jsdoc
99:1 error Missing JSDoc comment require-jsdoc
109:1 error Missing JSDoc comment require-jsdoc
140:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/books/model-datastore.js
19:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
40:1 error Missing JSDoc comment require-jsdoc
68:1 error Missing JSDoc comment require-jsdoc
70:7 error 'results' is never reassigned. Use 'const' instead prefer-const
88:1 error Missing JSDoc comment require-jsdoc
111:1 error Missing JSDoc comment require-jsdoc
135:1 error Missing JSDoc comment require-jsdoc
154:1 error Missing JSDoc comment require-jsdoc
171:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/config.js
85:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/lib/images.js
21:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
29:1 error Missing JSDoc comment require-jsdoc
37:1 error Missing JSDoc comment require-jsdoc
71:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/lib/oauth2.js
23:1 error Missing JSDoc comment require-jsdoc
66:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
72:1 error Missing JSDoc comment require-jsdoc
82:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/4-auth/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/books/model-cloudsql.js
35:1 error Missing JSDoc comment require-jsdoc
51:1 error Missing JSDoc comment require-jsdoc
67:1 error Missing JSDoc comment require-jsdoc
77:1 error Missing JSDoc comment require-jsdoc
97:1 error Missing JSDoc comment require-jsdoc
107:1 error Missing JSDoc comment require-jsdoc
138:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/books/model-datastore.js
19:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
40:1 error Missing JSDoc comment require-jsdoc
68:1 error Missing JSDoc comment require-jsdoc
70:7 error 'results' is never reassigned. Use 'const' instead prefer-const
88:1 error Missing JSDoc comment require-jsdoc
110:1 error Missing JSDoc comment require-jsdoc
133:1 error Missing JSDoc comment require-jsdoc
152:1 error Missing JSDoc comment require-jsdoc
169:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/config.js
85:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/lib/images.js
21:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
29:1 error Missing JSDoc comment require-jsdoc
37:1 error Missing JSDoc comment require-jsdoc
71:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/lib/oauth2.js
23:1 error Missing JSDoc comment require-jsdoc
66:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
72:1 error Missing JSDoc comment require-jsdoc
82:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/5-logging/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/books/model-cloudsql.js
36:1 error Missing JSDoc comment require-jsdoc
52:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
83:1 error Missing JSDoc comment require-jsdoc
104:1 error Missing JSDoc comment require-jsdoc
118:1 error Missing JSDoc comment require-jsdoc
149:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/books/model-datastore.js
20:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
41:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
71:7 error 'results' is never reassigned. Use 'const' instead prefer-const
89:1 error Missing JSDoc comment require-jsdoc
111:1 error Missing JSDoc comment require-jsdoc
135:1 error Missing JSDoc comment require-jsdoc
162:1 error Missing JSDoc comment require-jsdoc
179:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/config.js
91:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/lib/background.js
32:1 error Missing JSDoc comment require-jsdoc
46:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/lib/images.js
23:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
31:1 error Missing JSDoc comment require-jsdoc
61:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
103:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/lib/oauth2.js
23:1 error Missing JSDoc comment require-jsdoc
66:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
72:1 error Missing JSDoc comment require-jsdoc
82:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/6-pubsub/worker.js
63:3 error Unexpected var, use let or const instead no-var
94:1 error Missing JSDoc comment require-jsdoc
130:1 error Missing JSDoc comment require-jsdoc
172:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/books/model-cloudsql.js
36:1 error Missing JSDoc comment require-jsdoc
52:1 error Missing JSDoc comment require-jsdoc
68:1 error Missing JSDoc comment require-jsdoc
81:1 error Missing JSDoc comment require-jsdoc
101:1 error Missing JSDoc comment require-jsdoc
114:1 error Missing JSDoc comment require-jsdoc
145:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/books/model-datastore.js
20:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
41:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
71:7 error 'results' is never reassigned. Use 'const' instead prefer-const
89:1 error Missing JSDoc comment require-jsdoc
111:1 error Missing JSDoc comment require-jsdoc
134:1 error Missing JSDoc comment require-jsdoc
160:1 error Missing JSDoc comment require-jsdoc
177:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/books/model-mongodb.js
23:1 error Missing JSDoc comment require-jsdoc
32:1 error Missing JSDoc comment require-jsdoc
37:1 error Missing JSDoc comment require-jsdoc
58:1 error Missing JSDoc comment require-jsdoc
85:1 error Missing JSDoc comment require-jsdoc
112:1 error Missing JSDoc comment require-jsdoc
132:1 error Missing JSDoc comment require-jsdoc
160:1 error Missing JSDoc comment require-jsdoc
184:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/config.js
103:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/lib/background.js
32:1 error Missing JSDoc comment require-jsdoc
47:1 error Missing JSDoc comment require-jsdoc
51:3 error Missing JSDoc comment require-jsdoc
56:3 error Missing JSDoc comment require-jsdoc
96:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/lib/images.js
23:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
30:1 error Missing JSDoc comment require-jsdoc
55:1 error Missing JSDoc comment require-jsdoc
63:1 error Missing JSDoc comment require-jsdoc
96:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/lib/oauth2.js
23:1 error Missing JSDoc comment require-jsdoc
66:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
72:1 error Missing JSDoc comment require-jsdoc
82:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/7-gce/worker.js
52:1 error Missing JSDoc comment require-jsdoc
80:1 error Missing JSDoc comment require-jsdoc
114:1 error Missing JSDoc comment require-jsdoc
154:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/books/api.js
19:1 error Missing JSDoc comment require-jsdoc
23:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/books/crud.js
20:1 error Missing JSDoc comment require-jsdoc
24:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/books/model-cloudsql.js
36:1 error Missing JSDoc comment require-jsdoc
52:1 error Missing JSDoc comment require-jsdoc
68:1 error Missing JSDoc comment require-jsdoc
81:1 error Missing JSDoc comment require-jsdoc
101:1 error Missing JSDoc comment require-jsdoc
114:1 error Missing JSDoc comment require-jsdoc
145:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/books/model-datastore.js
20:12 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
41:1 error Missing JSDoc comment require-jsdoc
69:1 error Missing JSDoc comment require-jsdoc
71:7 error 'results' is never reassigned. Use 'const' instead prefer-const
89:1 error Missing JSDoc comment require-jsdoc
111:1 error Missing JSDoc comment require-jsdoc
134:1 error Missing JSDoc comment require-jsdoc
160:1 error Missing JSDoc comment require-jsdoc
177:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/books/model-mongodb.js
23:1 error Missing JSDoc comment require-jsdoc
32:1 error Missing JSDoc comment require-jsdoc
37:1 error Missing JSDoc comment require-jsdoc
58:1 error Missing JSDoc comment require-jsdoc
85:1 error Missing JSDoc comment require-jsdoc
112:1 error Missing JSDoc comment require-jsdoc
132:1 error Missing JSDoc comment require-jsdoc
160:1 error Missing JSDoc comment require-jsdoc
184:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/config.js
100:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/lib/background.js
32:1 error Missing JSDoc comment require-jsdoc
47:1 error Missing JSDoc comment require-jsdoc
51:3 error Missing JSDoc comment require-jsdoc
56:3 error Missing JSDoc comment require-jsdoc
96:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/lib/images.js
23:17 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
30:1 error Missing JSDoc comment require-jsdoc
55:1 error Missing JSDoc comment require-jsdoc
63:1 error Missing JSDoc comment require-jsdoc
96:16 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/lib/oauth2.js
23:1 error Missing JSDoc comment require-jsdoc
66:24 error A function with a name starting with an uppercase letter should only be used as a constructor new-cap
72:1 error Missing JSDoc comment require-jsdoc
82:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/test/_api-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/test/_crud-tests.js
20:3 error Split 'let' declarations into multiple statements one-var
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/test/app.test.js
44:3 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/optional-kubernetes-engine/worker.js
52:1 error Missing JSDoc comment require-jsdoc
80:1 error Missing JSDoc comment require-jsdoc
114:1 error Missing JSDoc comment require-jsdoc
153:1 error Missing JSDoc comment require-jsdoc
/Users/timmerman/Documents/github/nodejs-getting-started/test/e2e.js
34:1 error Missing JSDoc comment require-jsdoc
81:7 error 'numTests' is never reassigned. Use 'const' instead prefer-const
✖ 258 problems (258 errors, 0 warnings)
24 errors and 0 warnings potentially fixable with the `--fix` option.fhinkel commented
We don't extend Google in our other configs, see https://github.com/googleapis/nodejs-compute/blob/master/.eslintrc.yml
I'd prefer to stay consistent with the client libraries. Also, I believe the google style is not very common outside of google. cc @JustinBeckwith