Code Review follow up tasks
Closed this issue · 2 comments
jmound commented
- Call out that environment (prod v non-prod) are not considered in this demo #61
- Consider creating a “Known Issues” / “Gotcha” section in documentation. ie. That forsetti needs to be created before some variables can be set and re-applied #61
- Review for consistency with Google’s internal terraform standards guide #62
inshared.tf
, separate out variables and locals into separate files- where applicable, like where there are long service account names, use locals. Example #63
- Ensure commented descriptions on all IAM bindings #55
- Migrate to use CFT log-export module #54
- Remove unused cluster outputs #53
chroto commented