GoogleCloudPlatform/terraform-google-secured-data-warehouse

Provide concrete example of how to deploy examples onto Secure Foundation

marktomlinson1 opened this issue · 2 comments

marktomlinson1 commented

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave +1 or me too comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If the issue is assigned to a user, that user is claiming responsibility for the issue.

Description

Hints are provided on how to deploy the Secured Data Warehouse examples (e.g. simple-example) onto a platform based on the GCP terraform-example-foundation, however no concrete steps are provided and the reader is left to make a number of decisions and create a number of Terraform scripts which extend the ones provided by the foundation. It would be great if these could be packaged ready-to-go with the example.

My initial test deployment used the following:

  • Data Governance project prj-bu1-c-sdw-data-gov-xxxx in folder fldr-common, based on the foundation template for prj-bu1-c-infra-pipeline
  • Ingestion project prj-bu1-p-sdw-data-ing-xxxx in folder fldr-production, based on the foundation template for prj-bu1-p-sample-base
  • Non-Confidential data project prj-bu1-p-sdw-nconf-data-xxxx in folder fldr-production, based on the foundation template for prj-bu1-p-sample-base
  • Confidential data project prj-bu1-p-sdw-conf-data-xxxx in folder fldr-production, based on the foundation template for prj-bu1-p-sample-base

I used terraform-docs to create a default terraform.tfvars file in the simple-example folder and found I also needed to copy provders.tf from the foundation code into the same directory to avoid errors in the access context manager perimeter setup step.

Finally, I had to make some changes to main.tf in the simple-example folder to adjust the default region and change the bucket, dataset and keyring names to align to the foundation naming convention.

References

  • #0000
marktomlinson1 commented

Would also be very helpful to provide guidance on which project the example flex-templates should be built and deployed - e.g. data governance, data ingestion etc.

github-actions commented

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days