GoryMoon/GlobalGameRules

[1.19.2 / CRASH] Mod crashing the game on world creation.

murao-kun opened this issue · 12 comments

wendall911 commented

I can confirm this crash. It' is with a newer version of Forge after 43.1.27 that is not reading the config files early enough for mods to pick up in the startup process. I'm only seeing this: 43.1.30 Make ForgeConfigSpec$Builder.comment able to be called multiple times for the same entry. (#9056) Maybe that's the issue, no idea. Could just be a startup timing issue.

If starting with no config, game crashes before it is even generated.

I've had this problem on a couple of my mods. I had to move Config registration out of the Forge FMLConstructModEvent into the main function.

  • 👍1
wendall911 commented

I rebuilt locally using the safeRunForDist proxy as a dist executor. I'm not sure if it's what you want for a change, but it doesn't crash.

` public GlobalGR() {
Proxy proxy = DistExecutor.safeRunForDist(() -> Proxy::new, () -> Proxy::new);
proxy.constructMod();
MinecraftForge.EVENT_BUS.register(WorldEvents.class);
}

private class Proxy {
    private void constructMod() {
        ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, GGRConfig.commonSpec);
    }
}`
GoryMoon commented

Haven't been able to replicate this issue on multipe computers running only with this mod.
If you could post the debug.log or latest.log from a crash it might be helpful in finding the real issue.

ChasrielS commented

I also have this crash.
debug.log
latest.log
crash-2022-11-02_23.07.02-server.txt
Hope you can fix it

  • 👍1
Houtblokje commented

I am having the same issue. I have also noticed the config file not generating.

  • 👍1
GoryMoon commented

@ChasrielS Your files are empty, probably some issue when uploading them.
I would prefer a paste site rather then uploading the file, like:

Deleted user commented

I choose to upload the file and submit it for the last time. If it still can't be fixed, forget it!
crash-2023-01-09_10.30.54-server.txt
latest.log

  • 👍1
Deleted user commented

If you can't reproduce, I'll upload a modpack.
modpack.zip

lynnpye commented

For what it's worth, I have found at least one mod which, when included with this one, triggers the crash consistently:

https://www.curseforge.com/minecraft/mc-mods/better-mob-griefing-control

In CurseForge, if I create a custom modpack with GGR, at Forge 43.2.7, it works. If I include Better Mob Griefing Control along with GGR, GGR crashes. And of course, BMGC is part of a larger modpack I have already been running successfully, so I know it works too.

I suspect it is a load order issue as well, given @wendall911 's workaround.

EDIT: It also appears that a combination of GGR and Twilight Forest (https://www.curseforge.com/minecraft/mc-mods/the-twilight-forest) will crash to desktop upon world creation.

Wimblerrr commented

I have the same issue, although I noticed it only happens if I set a global Command so that it's running the command upon world creation

BlackAures1 commented

Are there plans to fix this crash?

BlackAures1 commented

crash-2023-05-24_21.56.46-server.txt
crash-2023-05-24_21.48.26-server.txt
debug.log
latest.log
It enters the menu correctly, but crashes when you try to open the old world (new world too)