IODynamicClass redundant init variables
Retiefasuarus opened this issue · 1 comments
Retiefasuarus commented
Is obs_data
, sim_data
necessary for the IODynamic class if it reads files?
@chyalexcheng
def __init__(
self,
sim_name: str,
sim_data_dir: str,
sim_data_file_ext: str,
obs_data_file: str,
obs_names: List[str],
ctrl_name: str,
num_samples: int,
param_min: List[float],
param_max: List[float],
obs_data: np.ndarray = None,
ctrl_data: np.ndarray = None,
inv_obs_weight: List[float] = None,
sim_data: np.ndarray = None,
callback: Callable = None,
curr_iter: int = 0,
param_data_file: str = '',
param_data: np.ndarray = None,
param_names: List[str] = None,
):
chyalexcheng commented
Yes, the inference class still needs them to calculate the likelihood.