Add/Change Next Page Button
Opened this issue · 12 comments
It is tedious to progress to the next page in PDF files due to the next page button being inside the app menu.
It would be beneficial to add the next page button to the right of the previous page button, which is easily accessible outside of the menu, or replace the previous page button with the next page button, since the next page is used much more than the previous page button when progressing through a PDF file.
Both the previous and next page buttons are outside of the expanded menu, at least if you aren't on some tiny screen.
Please provide a screenshot because it shouldn't be that way. If it's due to using it on a tiny screen size, I don't think there's much we can do about it.
Thank you for your reply.
My device is Google Pixel 4a (5G) with the latest GrapheneOS Stable after update check.
Screenshot has been attached.
I'm not able to reproduce it. Both buttons are visible here. It looks like you've increased Display size to Large from Default and it's only able to display 2 buttons in the action bar rather than 3. I don't know if there's anything we can do about it. Maybe we can configure it to more aggressively display buttons in the bar regardless of available space. It's very conservative right now.
I checked and can confirm that you are correct. I did increase the display size to Larger, due to the small button and menu size on the phone. After decreasing the display size to Large, the next page button has appeared in PDF Viewer.
I am surprised by the aggressiveness of the button hiding, because there is enough space for 1-2 extra buttons at the top of PDF Viewer screen. Whether PDF Viewer is adjusted for this issue or not, I thank you for your assistance.
I think that this is just how the action bar UI that it uses works including in other apps. It's able to display more than just the previous and next buttons as action buttons too, it's just that there's never enough room for it to want to do it.
We can see if we can configure it to show more buttons. I've already wanted to do that in the past because it's inconvenient needing to use the menu for actions beyond prev/next too. I didn't see any easy way to do it when I checked before and I don't know if there's some other androidx library, etc. we could use to provide it. I don't want a custom action bar implementation.
I agree. Personally, if I was adding a third button to the action bar, I would choose either Open document or Jump to page. Open document is likely the most suitable candidate for this.
Yes it would just do it based on the order in the menu.
It already supports it, and I already added button icons for most of them so that they could be displayed in the action bar at least in landscape mode or a tablet. It doesn't make sense to me that it's so conservative, but I wasn't the one who decided that and don't know how to change it.
That's what I was thinking. The fact that Open document is first in the menu list is convenient.
I agree with your opinion on how conservative it is. I also noticed that, as you stated earlier, other apps have the same button hiding problem which has been at least partially fixed by lowering my display size. Android is too strict with the button hiding. It is not great for people who require larger display sizes due to visual impairment etc.
I will search around both the internet and the OS code to try to find possible ways of fixing this problem. Currently, I am nowhere near as experienced as you with matters such as this, but I have some basic knowledge and understanding of code.
I will update this issue if I find anything, unless you specify a preferred method.