Gravemind/tt-rss-feedlish-theme

Feed name button not present when looking at specific feed

Closed this issue · 5 comments

jamespo commented

If I look at a specific feed the button with the feed name for each article isn't there - there is a gap instead

image

The button isn't there with the default theme either, but there's no gap

Gravemind commented

Yes, I couldn't find a proper solution yet.

I think it's a change after 18.8: now, tt-rss emits the emplacement for the feed name, but the name inside is empty. At 18.8, I think the whole emplacement wasn't emitted at all.

If I cannot find a solution, I might send a couple Issues or PRs to tt-rss...

levito commented

I kind of solved this by setting the width not on .feed but on the contained .feed a while also hiding .feed a:empty. See levito/tt-rss-feedly-theme@a407092.

The downside of this is that feed names don't shrink anymore if they are shorter. For me this was an acceptable compromise.

Gravemind commented

Thanks @levito ! For now, I personally prefer to keep the short feed title version.

I made a PR to tt-rss with the most PR-worthy fix I found.

Gravemind commented

tt-rss has now a neat is-vfeed attribute (Thanks fox ) to deal with this issue in themes.

@levito: here is how I used it.

  • 👍1
levito commented

Awesome, thanks! I also use it now

  • 👍1