Graylog2/graylog-plugin-beats

Await inside BeatsFrameDecoder

hc4 opened this issue · 1 comments

hc4 commented

I found this line in BeatsFrameDecoder.sendACK:
channel.write(buffer).awaitUninterruptibly();
Why should we block I/O thread to wait write operation?
Is it possible to receive duplicate message, if won't wait?
Or Netty is smart enough to not block in such case?

@hc4 Good catch, thanks!