climb / conventional checkbox sense is inverted
Closed this issue · 6 comments
I'm running the linux appimage version 4.1.9.
I have a roughing pass, and an outline pass.
Roughing seems to do all of its steps in conventional (CCW for an interior cut) direction.
If I don't check the "Conventional" box for the outlining pass, it cuts the same way as roughing did. If I check the Conventional box, the direction switches to CW.
Can provide export .kmz if needed.
lmk if this .kmz is an accurate reproduction of the issue.
From my testing, I've found that:
Rough seems to alternate between climb and conventional.
When the outline conventional override is checked, it uses climb milling (material on left side)
When the outline conventional override is unchecked, it uses conventional milling (material on right side)
It seems that the outline issue is stemming from this line in ops.js
I cant find any other places in the code where process.camOutlinePocket is used, except as a renamed prop for legacy support. I'm going to go ahead and remove it.
Yes, your repro zip reproduces the problem. TBH, I can't tell what direction the animation is going in Rough, because I can't make it slow enough. Not sure why not. Outline I can slow down.
If I turn on Roughing for the outside, somehow it slows everything down. (?!) (I have feed set to '1', and animation set to '1x'.)
In any case, with roughing turned on for both inside and outside, it's clear that climb/conventional alternates for the internal clearing levels -- probably as a side-effect of optimizing movement by going outward/inward/outward. Without the checkbox checked (i.e., climb selected), the first pass of the inside and all of the passes for the outside, are done in climb. Checking the box reverses the first pass of the inside, and all of the passes for the outside.
So this supports your hypothesis that it's a bug in outlining only.
@bakedPotatoLord agree this is leagacy code. can remove from config.js as well.
Merged. deploying to prod this weekend