[Feature Request] Any Thaumcraft file name (Incompatibility with Bansoukou)
Closed this issue · 8 comments
I making modpack E2E-E.
To fix issue with Web and researches, i need to use Bansoukou mod, that patches Thaumcraft .jar file.
The problem, is after patching, it changes its name to Thaumcraft-1.12.2-6.1.BETA26-patched.jar. This makes ThaumTweaks crash on startup with this crashlog:
debug.log
So, two requests:
- Please add error handling for case when Thaumcraft file was renamed.
Right now i had no clue why my game crashes, and only accidentally understand that it was ThaumTweaks.
It would be nice if game crashed with verbose error, likeThaumcraft-1.12.2-6.1.BETA26.jar not found for ThaumTweaksor such.
- Please add feature to handle renamed files.
It could be glob file search, like
Thaumcraft-*.
Or please just add second possible TC file name asThaumcraft-1.12.2-6.1.BETA26-patched.jarespecially for Bansoukou.
Instead of doing this, update your mod to depend MixinBooter. the archaic way of manually appending a specific jar on the classpath is very incompatible with the current 1.12.2 ecosystem. Not to mention packing mixins brings forth more problems.
Ive never heard about this technology before. Using hardcoded file name is obviously a problem so I will try to migrate.
No problem, its hard getting word out there about 1.12.2 since its pretty much a banned version on Forge's discord, forums and a lot of other places. https://github.com/CleanroomMC will keep you updated if you're still on 1.12.2.
Uploaded on CurseForge
Good stuff!
Does it work? I did some testing but its impossible to try everything
I'm gonna test it in a week or so.
Well, its actually working! Forget to mention that.
Thank you for the fix.