GroceriStar/graphql-server

install sd-wrapper, connect it to resolvers and see if everything will work or not

atherdon opened this issue · 19 comments

atherdon commented
  1. setup project locally Done
  2. install sd-wrapper. our module https://github.com/GroceriStar/sd#quick-start Done
  3. comment previous versions and use a new version here: https://github.com/GroceriStar/graphql-server/blob/master/src/data/selector.js
    as we make it in smart way previously, all methods located in one file, instead of checking all files
  4. run this server, run tests - does it work? nothing crashing? it's strange :)
atherdon commented

you actually can start to setup this server locally. i think all will be pushed during that time

atherdon commented

Our goal will be to make this part: Food-Static-Data/sd#294 (comment)

Edebo commented

at issue#294 i already installed sd-wrapper locally and uncommented the moved functions in the https://github.com/GroceriStar/sd/tree/master/generator/projects/GraphQL/test.

step 2 in this issue# 145 isnt clear to me.i dont understand how it comes to picture

atherdon commented

emm. confused.
sd-wrapper is our small separated module, that store data.
inside sd-wrapper we have a few functions, that change the structure of our data
inside sd-wrapper we have some tests, because we want to check that data is solid.

this repository(graphql-server) is a separated thing. it's an actual place and reason, why we're building sd-wrapper.

So, you need to fork this repository, install packages, install sd-wrapper and launch it locally.
tell me if this is not clear.

Example: sd-wrapper is like HDD. graphql-server is like a PC-box, that contain HDD

Edebo commented

i get the explanation of graphql-server and sd-wrapper
but i dont know if this is what you want me to do
i git clone graphql-server locally.then i npm installed sd-wrapper.then npm run test
graphql

atherdon commented

looks good and test working. open pull request so i can take a look and give you more detailed answer

Edebo commented

saying no compare to make when trying to pull request

atherdon commented

hmm. as from your screenshot i see at least one change :) i mean if you install sd-wrapper - package.json should be changed.
did you also start to make an adjustments at selectors.js? you can comment that 4th line - we wouldn't need it soon(at least by my knowledge
)

atherdon commented

i think i see M near package.json - maybe you just didn't commit it :0

atherdon commented

ok, tell me if next step of this task is not clear for you

Edebo commented

yes not clear

atherdon commented

2.5 connect files, that we have created from methods, that we copy, from fetch plugin: Food-Static-Data/sd#294
as i understand - we need to have 7 files(based on 294 list)

atherdon commented

ok, right now you need to run this expressjs server and tell me if it works fine or crashes

Edebo commented

server

Edebo commented

worked fine

atherdon commented

Ok, looks like we did it!
We have this part in "a gray area": https://github.com/GroceriStar/graphql-server/blob/master/src/data/selector.js#L88-L103 but i think we need to talk with Vadim about it, because i'm not sure if our sd-wrapper has that functions moved yet.

atherdon commented

Le'ts close it and i'll check the next task for you

Edebo commented

ok.have seen the functions.i will wait for the decision.yes boss,lets close it