add deepEqualAdded

Question

add deepEqualAdded

GrosSacASac opened this issue 5 years ago · 8 comments

GrosSacASac commented 5 years ago

Similar to deepEqual which should work with RegExp, Date, Map, Set and Typed Arrays

Answer 1 · 2019-10-04T08:34:12.000Z

could you spec this out a bit more?

Answer 2 · 2019-10-04T08:52:13.000Z

I will add some (failing) tests

Answer 3 · 2019-10-04T09:08:19.000Z

I added some tests that should pass
https://github.com/GrosSacASac/utilsac/blob/master/tests/specification/deepEqual.js#L194

Answer 4 · 2019-10-08T20:27:39.000Z

I added a placeholder inside deep.js

Are you still working on it ?

Answer 5 · 2019-10-09T18:43:32.000Z

If @mishabruml isn't interested in doing this, I have a working implementation of this that I can submit for approval. As it's your call @GrosSacASac, I don't want to overstep someone else giving it a shot.

Answer 6 · 2019-10-09T20:20:07.000Z

Yes, please do

Answer 7 · 2019-10-09T20:23:35.000Z

@jmeline I added you so you can push directly

Answer 8 · 2019-10-09T21:55:56.000Z

Thanks @GrosSacASac, I put out a PR for feedback but I can merge it immediately if you prefer.