GrumpyOldPizza/ArduinoCore-stm32l0

// Exposing .getVBAT() pins //

salvagione opened this issue · 0 comments

.getVBAT only works if there's a voltage divider on the board AND the pins are set in the variant.h. The Gnat's voltage divider is toggled on/off by a digital pin, super clever. Where as the LoRaSensorTile's voltage divider is tied to VBAT. The analog pin is the same for both devices. Exposing the pins in the function call would be nice. .getVBAT() would continue to work with the pins defined in the variant.h file. .getVBAT(A0) and .getVBAT(A0, D1) would the caller to define/override the analog pin as well as the on/off pin if used. BTW your library is a delight to use.