Gurkengewuerz/matrix-bot

TeamCity integration improvements

Opened this issue · 1 comments

As the installation was quite difficult, the following things could be improved:
General:

TeamCity plugin:

  • I don't see a reason for the build config filter as the Webhook plugin in TeamCity lets me already filter the build configs
  • The failed state is called "failure" (https://github.com/Gurkengewuerz/matrix-bot/blob/main/plugins/teamcity.js#L58)
  • It would be nice to be able to configure the messages at a config file instead of the js file (e.g. I added the branch name to the message with on branch <code>" + buildBranch + "</code>)

Hey @kaenganxt. First of all thanks for testing this bot and setting it up!
The easier things are fixed. I will add a templating option to support customization and also language customization but it requires some time.
I also try to be dynamic on the webhooks but i have to look at it again.

P.S. wow.... github closes this issue automatically after mentioned "fixed" 🙃