HMaker/aiohttp-socks5

Can't Requests Using Public Socks5 Proxies

MrCoder1453 opened this issue · 1 comments

First,
Thanks for creating such a perfect library, you are a life saver.

This is not a problem for me anymore, I have changed my proxy settings but your library does not support proxies which don't have username and password auth,

I mean, you can't requests like that:

proxy = "socks5://proxyip"
session.get(url=url,proxy=proxy)

it supports,

proxy = "socks5://username@password:proxyip"
session.get(url=url,proxy=proxy)

For guys, who use socks5 proxy for free from internet, this may cause problems. Because most of them doesn't have username and password auth.

I really appreciate if you solve this problem.

Thanks in advance.

What's the error raised? Is it an error from the SOCKS server? Actually the library doesn't enforces proxy URL to have username or password.

On authentication negotiation the library always sends the USERNAME method, probably your SOCKS server is replying to that and asking for a username instead of replying with NO AUTHENTICATION REQUIRED method.