HPDCS/ROOT-Sim

do we still need to update `min_in_transit`?

Closed this issue · 1 comments

Looking at the code I was wondering if it is still necessary to store the minimum timestamp of buffered messages into the outgoing queue. At least for the GVT calculation it shouldn't be necessary.

// Store the minimum timestamp of outgoing messages
if(msg->timestamp < LPS[current_lp]->outgoing_buffer.min_in_transit[LPS[current_lp]->worker_thread]) {
LPS[current_lp]->outgoing_buffer.min_in_transit[LPS[current_lp]->worker_thread] = msg->timestamp;

Maybe I'm wrong :)

Not anymore!
This was used by the timestretch branch which will be eventually integrated into the develop branch. yet, along time, this has been superseded by different facilities which are later used in this module:

https://github.com/HPDCS/ROOT-Sim/blob/timestretch/src/scheduler/preempt_callback.S#L75

So this will be removed.