do we still need to update `min_in_transit`?
Closed this issue · 1 comments
ael-code commented
Looking at the code I was wondering if it is still necessary to store the minimum timestamp of buffered messages into the outgoing queue. At least for the GVT calculation it shouldn't be necessary.
ROOT-Sim/src/communication/communication.c
Lines 339 to 341 in 5e1487d
Maybe I'm wrong :)
alessandropellegrini commented
Not anymore!
This was used by the timestretch
branch which will be eventually integrated into the develop
branch. yet, along time, this has been superseded by different facilities which are later used in this module:
https://github.com/HPDCS/ROOT-Sim/blob/timestretch/src/scheduler/preempt_callback.S#L75
So this will be removed.