Exiting the interactive shell does *not* explicitly unbuild the topology
Closed this issue · 4 comments
When typing exit() or ctrl+D in the interactive shell, the topology is not explicitly un-built (or destroyed).
Even though this behavior may be ok in platforms where the associated processes are local to the computer running topology, this is an error when it is necessary to clean up remote resources (e.g. stop a remote HTTP web service).
One way to solve is by catching the SystemExit exception when topology.interact.interact() is called and
instruct the Topology manager to "unbuild" the topology.
It actually does explicitly unbuild the topology:
$ topology test/test_vlan.py --platform=docker
Starting Network Topology Framework v1.3.0
Building topology, please wait...
Engine nodes available for communication:
ops1, hs1, hs2
>>>
Unbuilding topology, please wait...
I ran some experiments and found out the following statemente is partially false:
When typing exit() or ctrl+D in the interactive shell, the topology is not explicitly un-built (or destroyed).
The issue only occurs when calling exit(). Crtl-D works fine
@sergiosmcr good catch. I'll submit a patch soon.
Fixed in 6c6e517 . In queue for release 1.4.0.