Should the PExpectShell class handle the pexpect EOF and TIMEOUT exceptions?
Closed this issue · 1 comments
This responsibility can be easily left for the child class, and one argument against is that if this is implemented, the user of the PExpectShell class loses the control of these exceptions, but since the PExpectShell class is already wrapping some pexpect methods, the user is already losing the control of them (which is necessary since the purpose of this class is to make it easy to use pexpect with shells).
Are these methods and the EOF or TIMEOUT exceptions in an analogous situation? Should the PExpectShell class handle these exceptions in some way?
What would be the benefit of wrapping this exceptions? Currently, the traceback of those exceptions is very complete. I don't see any benefit in wrapping them. It will only hide the underlying complexity of the system. We built a shell class that allows to use the shell in a consistent way, but the underlying system will continue to use pexpect. So. No.