HXLStandard/hxl-proxy

Give less information for an HTML dataset

davidmegginson opened this issue · 5 comments

davidmegginson commented

Possibly return a 404 "No data found" instead of saying that it's HTML, so that the Proxy can't be used for pinging.

davidmegginson commented

Note that /data/tagger and /data/edit catch their own exceptions and show the error internally. That needs to be changed for the HTML markup exception.

teodorescuserban commented

@davidmegginson, I think the last commit fails the tests.

davidmegginson commented

They were failing because requirements.txt was using libhxl==4.26 instead of the dev branch HEAD. I changed the file, and thought it passed after that, but might have misunderstood.

teodorescuserban commented

It is recommend to keep referring in the requirements.txt to the proper branch / tag of libhxl-python that it should use, and only change it to the new tag once everything is done and the libhxl-python has already been released; making this part of the new hxl-proxy tag creation process should be ideal.

davidmegginson commented

Thanks, @teodorescuserban — I've added that to step 5 here: #401