Haidra-Org/hordelib

Does `shared_model_manager.manager.lora.download_default_loras()` potentially lead to a hang up?

Closed this issue · 2 comments

tazlin commented

The prior round of testing used this fixture for the lora inference tests:

    @pytest.fixture(autouse=True, scope="class")
    def setup_and_teardown(self, shared_model_manager: type[SharedModelManager]):
        assert shared_model_manager.manager.lora
        shared_model_manager.manager.lora.download_default_loras()
        shared_model_manager.manager.lora.wait_for_downloads()
        yield
        shared_model_manager.manager.lora.stop_all()

Which, when run on my machine (and particularly through the CI runner), would hang here indefinitely during full CI runs, but not when the lora inference tests were first or run on their own.

Does running the lora model manager, or some other test(s) lead to this hang up in certain circumstances?

tazlin commented

This is happening again on a064615. I feel that something is happening during the CI that might not be happening in production that is causing this. This is the second PR round where it is specifically timing out during wait_for_downloads where the file is already on disk.