Colour window: monochromatic and askew

Question

Colour window: monochromatic and askew

Opened this issue 3 years ago · 5 comments

Something's wrong with the colour panel:

Answer 1 · 2022-04-23T08:19:41.000Z

Can you try reverting https://cgit.haiku-os.org/haiku/commit/src/kits/interface/Bitmap.cpp?id=6211ae257544d7a1453bc34297c8eac3e2b0435d and see if it makes a difference?

Answer 2 · 2022-04-23T08:54:23.000Z

Good catch! Reverting that commit does indeed fix the issue.

Answer 3 · 2022-10-01T19:04:54.000Z

Has Haiku been updated yet such that it has fixed this issue?

Answer 4 · 2022-10-04T08:33:54.000Z

It has not, this issue is still with us. I have no idea if the commit @pulkomandy linked can easily be reverted and fixed another way, or if Becasso could be fixed more easily...
As is, Becasso is pretty useless. Or at least, colourless... :)

Answer 5 · 2022-10-04T09:00:03.000Z

@jscipione do you have an opinion here? I think the previous code in BBitmap was behaving identically to BeOS at least for BeCasso case. So the fix for Spirograph is either incorrect or incomplete.

It wouldn't be difficult to fix BeCasso (use ImportBits instead of SetBits, probably) but it would be nice to try to have the old SetBits behave as close as possible to BeOS still?