Cover the component with unit test

Question

Cover the component with unit test

HaithemMosbahi opened this issue 6 years ago · 4 comments

In order to improve the component code and to reduce potential bugs and also to make it easy to maintain we need to cover the ngx-avatar component with unit test.

Answer 1 · 2018-10-03T11:32:21.000Z

I'm working on this one, I started by refactoring / covering the avatar.service. Here's the branch

Answer 2 · 2018-10-29T12:49:08.000Z

should be closed when this branch gets merged #46

Answer 3 · 2018-11-01T00:13:50.000Z

I think it's ready, isn't it?

Answer 4 · 2018-11-02T13:53:34.000Z

I still need to cover some scenarios in the avatar.component.spec.ts
The goal is to cover the maximum features to avoid bugs / regression. I think after that we will be able to confidently auto publish to npm when we merge to master